Auto encrypted publish when recps is set #212
Conversation
|
|
Benchmark results
|
db.js
Outdated
| if (msg.recps) { | ||
| msg = ssbKeys.box( | ||
| msg, | ||
| msg.recps.map((x) => x.substr(1)) |
There was a problem hiding this comment.
This only supports classic encryption. A good start but we need an interface like add Boxer and addUnboxer right?
There was a problem hiding this comment.
Yes, but I would rather do that in #90. Would like ssbc/ssb-fixtures#2 to be in a bit better shape before really looking at that again though.
There was a problem hiding this comment.
Hmm, I was looking at that x.substr(1) and got confused. Do we need to remove the sigil @?
According to ssb-keys implementation, yes:
https://github.com/ssb-js/ssb-keys/blob/98569aa430e344b3ed144fcebf5d2755f7355bf6/index.js#L139
But according to how Patchwork does it right now, it checks if it's a Ref.isFeed():
How does Patchwork even work?
There was a problem hiding this comment.
There was a problem hiding this comment.
Given that it also works that way I'm open to maybe doing this without the substr. What do you think?
There was a problem hiding this comment.
Yeah this substr here seems not necessary if ssb-keys does it in utils.toBuffer
Benchmark results
|
Benchmark results
|
To fix #211. Current behaviour can be a bit of a gotcha when coming from db1. First commit is just a failing test.